Configure GitHub workflows to use concurrency cancel-in-progress for pull requests#8171
Conversation
pull requests see recommended best practices at Apache https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=GitHub+Actions+Recommended+Practices Signed-off-by: Aurélien Pupier <apupier@ibm.com>
637b19c to
b210f28
Compare
|
the canceled job (marking the PR as failure) is unrelated to the PR change. Any chance to have it reviewed please? |
|
Anyone can review please? Currently there are several jobs in the queue and just for last few hours and looking at a single PR checks we could have saved several hours of compute time (see https://github.com/apache/paimon/actions/workflows/e2e-tests-flink-2.x-jdk11.yml and look for same branch triggered several times in few minutes between them) |
|
trying by mentioning some of the most active contributors to have more chance that it is noticed as i think that given it is impacting a bit all Apache projects using GitHub actions, this is important enough: |
|
Thanks for filling in the missing concurrency configs! The concurrency pattern is inconsistent across this PR: utitcase-jdk11.yml uses cancel-in-progress: true while the other 4 files use cancel-in-progress: ${{ github.event_name == 'pull_request' }}. Also, e2e-tests-flink-1.x.yml already had a |
When the workflow can be triggered only by pull_request event, I proposed a simplified value for cancel-in-progress.
this one I changed it to align with other concurrency declaration. |
see recommended best practices at Apache
https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=GitHub+Actions+Recommended+Practices
Purpose
Configure GitHub workflows to use concurrency cancel-in-progress for pull requests. it will allow to reduce workloads of GitHub workflows for Apache organization
Tests